SonarQube CRITICAL CODE_SMELL: Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allo #733

New issue

Closed

opened 2026-06-12 00:32:58 -05:00 by forgejo-actions · 1 comment

forgejo-actions commented

2026-06-12 00:32:58 -05:00

SonarQube issue detected.

SonarQube key: 7e7647ff-6d1d-41cf-b8a3-a2658839016f
Severity: CRITICAL
Type: CODE_SMELL
Location: myvideogamelist:app/Http/Controllers/Admin/UserController.php:284
Message: Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed.

https://sonarqube.linuxbox.ninja/project/issues?id=myvideogamelist&issues=7e7647ff-6d1d-41cf-b8a3-a2658839016f&open=7e7647ff-6d1d-41cf-b8a3-a2658839016f

SonarQube issue detected. **SonarQube key:** `7e7647ff-6d1d-41cf-b8a3-a2658839016f` **Severity:** `CRITICAL` **Type:** `CODE_SMELL` **Location:** `myvideogamelist:app/Http/Controllers/Admin/UserController.php:284` **Message:** Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed. https://sonarqube.linuxbox.ninja/project/issues?id=myvideogamelist&issues=7e7647ff-6d1d-41cf-b8a3-a2658839016f&open=7e7647ff-6d1d-41cf-b8a3-a2658839016f

forgejo-actions added the

labels

2026-06-12 00:32:58 -05:00

Codex self-assigned this

2026-06-12 09:14:56 -05:00

Codex added

and removed

labels

2026-06-12 09:14:56 -05:00

Codex commented

2026-06-12 09:28:58 -05:00

Member

Fixed

Reduced cognitive complexity in production sync helpers and specialized sync commands by extracting validation, write, payload, and target-safety helpers.
Reduced UserFriendController::store() branching by extracting self-friend and friendship persistence helpers.
Split admin/user and settings media URL resolution into small path and storage helpers.
Moved the Profile social-handle validation rule into the persistence trait that uses it.
Split long Pest helper functions into setup/assertion helpers.
Moved private admin game form, IGDB, lookup, and media helpers into SupportsGameForms, reducing Admin\GameController to 20 declared methods.
Added UnknownUserSiteSettings for the migration guard instead of throwing a generic runtime exception.

Commit: 85719ea

Verification

vendor/bin/pint --dirty --format agent
git diff --check
php artisan test --compact tests/Feature/Settings/ProfileUpdateTest.php tests/Feature/SyncProdProfileCommentsCommandTest.php tests/Feature/SyncProdUserSiteSettingsCommandTest.php tests/Feature/SyncDevOgFavoritesCommandTest.php tests/Feature/NewlyAddedGamesPageTest.php tests/Feature/PlatformIndexTest.php tests/Feature/AdminGameIgdbCreateTest.php tests/Feature/AdminGameGenreTest.php tests/Feature/AdminGameRegionalOrderingTest.php tests/Feature/AdminGameCleanupTest.php tests/Feature/GameRequestTest.php tests/Feature/UserFriendTest.php

Result: 145 passed, 1372 assertions.

## Fixed - Reduced cognitive complexity in production sync helpers and specialized sync commands by extracting validation, write, payload, and target-safety helpers. - Reduced `UserFriendController::store()` branching by extracting self-friend and friendship persistence helpers. - Split admin/user and settings media URL resolution into small path and storage helpers. - Moved the Profile social-handle validation rule into the persistence trait that uses it. - Split long Pest helper functions into setup/assertion helpers. - Moved private admin game form, IGDB, lookup, and media helpers into `SupportsGameForms`, reducing `Admin\GameController` to 20 declared methods. - Added `UnknownUserSiteSettings` for the migration guard instead of throwing a generic runtime exception. Commit: `85719ea` ## Verification ```bash vendor/bin/pint --dirty --format agent git diff --check php artisan test --compact tests/Feature/Settings/ProfileUpdateTest.php tests/Feature/SyncProdProfileCommentsCommandTest.php tests/Feature/SyncProdUserSiteSettingsCommandTest.php tests/Feature/SyncDevOgFavoritesCommandTest.php tests/Feature/NewlyAddedGamesPageTest.php tests/Feature/PlatformIndexTest.php tests/Feature/AdminGameIgdbCreateTest.php tests/Feature/AdminGameGenreTest.php tests/Feature/AdminGameRegionalOrderingTest.php tests/Feature/AdminGameCleanupTest.php tests/Feature/GameRequestTest.php tests/Feature/UserFriendTest.php ``` Result: `145 passed, 1372 assertions`.

Codex

2026-06-12 09:28:59 -05:00