SonarQube MAJOR CODE_SMELL: This method has 4 returns, which is more than the 3 allowed. #743

New issue

Closed

opened 2026-06-12 09:32:42 -05:00 by forgejo-actions · 1 comment

forgejo-actions commented

2026-06-12 09:32:42 -05:00

SonarQube issue detected.

SonarQube key: 0b46e3dc-23ca-4d2a-8165-9dac811595c5
Severity: MAJOR
Type: CODE_SMELL
Location: myvideogamelist:app/Console/Commands/Concerns/SyncsProdTables.php:16
Message: This method has 4 returns, which is more than the 3 allowed.

https://sonarqube.linuxbox.ninja/project/issues?id=myvideogamelist&issues=0b46e3dc-23ca-4d2a-8165-9dac811595c5&open=0b46e3dc-23ca-4d2a-8165-9dac811595c5

SonarQube issue detected. **SonarQube key:** `0b46e3dc-23ca-4d2a-8165-9dac811595c5` **Severity:** `MAJOR` **Type:** `CODE_SMELL` **Location:** `myvideogamelist:app/Console/Commands/Concerns/SyncsProdTables.php:16` **Message:** This method has 4 returns, which is more than the 3 allowed. https://sonarqube.linuxbox.ninja/project/issues?id=myvideogamelist&issues=0b46e3dc-23ca-4d2a-8165-9dac811595c5&open=0b46e3dc-23ca-4d2a-8165-9dac811595c5

forgejo-actions added the

labels

2026-06-12 09:32:42 -05:00

Codex self-assigned this

2026-06-12 09:51:59 -05:00

Codex added

and removed

labels

2026-06-12 09:52:00 -05:00

Codex commented

2026-06-12 09:58:34 -05:00

Member

Fixed

Reduced syncTableFromProduction(), SyncProdProfileComments::handle(), and SyncProdUserSiteSettings::handle() to a single final exit-code return.
Replaced the 9-parameter shared sync writer with an options array.
Extracted the friend-add JSON status code before the response ternary to remove the nested ternary.

Commit: c81ca49

Verification

vendor/bin/pint --format agent app/Console/Commands/Concerns/SyncsProdTables.php app/Console/Commands/SyncProdProfileComments.php app/Console/Commands/SyncProdUserSiteSettings.php app/Http/Controllers/UserFriendController.php
git diff --check
php artisan test --compact tests/Feature/SyncProdProfileCommentsCommandTest.php tests/Feature/SyncProdUserSiteSettingsCommandTest.php tests/Feature/SyncProdRolesCommandTest.php tests/Feature/SyncDevOgFavoritesCommandTest.php tests/Feature/UserFriendTest.php

Result: 26 passed, 195 assertions.

## Fixed - Reduced `syncTableFromProduction()`, `SyncProdProfileComments::handle()`, and `SyncProdUserSiteSettings::handle()` to a single final exit-code return. - Replaced the 9-parameter shared sync writer with an options array. - Extracted the friend-add JSON status code before the response ternary to remove the nested ternary. Commit: `c81ca49` ## Verification ```bash vendor/bin/pint --format agent app/Console/Commands/Concerns/SyncsProdTables.php app/Console/Commands/SyncProdProfileComments.php app/Console/Commands/SyncProdUserSiteSettings.php app/Http/Controllers/UserFriendController.php git diff --check php artisan test --compact tests/Feature/SyncProdProfileCommentsCommandTest.php tests/Feature/SyncProdUserSiteSettingsCommandTest.php tests/Feature/SyncProdRolesCommandTest.php tests/Feature/SyncDevOgFavoritesCommandTest.php tests/Feature/UserFriendTest.php ``` Result: `26 passed, 195 assertions`.

Codex

2026-06-12 09:58:34 -05:00