MyVideoGameList/myvideogamelist.com
MyVideoGameList/myvideogamelist.com
3
0
Fork 0
Code Issues 45 Pull requests Projects 3 Releases Activity Actions

Fix Localhost Links in Most Popular Game Cards #765

New issue
Closed
opened 2026-06-19 14:22:04 -05:00 by Veilor · 2 comments
Veilor commented 2026-06-19 14:22:04 -05:00
Member
Copy link

The most popular game cards should link to real MyVideoGameList game and platform pages, not localhost URLs that only work in a local development environment.

The current-year and upcoming popular game cards are shown across public pages, so broken host-specific links make the ranked game lists unusable for visitors even when the card content renders correctly.

Scope

  • Current-year Most Popular Games card links.
  • Most Popular Upcoming Games card links.
  • Generated game detail URLs used for title and box art links.
  • Generated platform URLs shown under popular game rows.
  • Existing populated and empty-state card layouts.

Acceptance Criteria

  • Game title links in both popular cards navigate to the correct game detail route.
  • Box art links in both popular cards use the same valid game detail route as the title.
  • Platform links continue to navigate to the correct platform route when platform metadata is present.
  • Rendered popular-card HTML does not contain hardcoded localhost URLs.
  • Empty popular-card states continue to render when no games qualify.
  • The existing public page layout and light/dark styling are preserved.

Test Coverage Required

  • Extend MostPopularGamesCardTest to assert current-year game links are route-based and do not contain localhost.
  • Extend MostPopularUpcomingGamesCardTest to assert upcoming game links are route-based and do not contain localhost.
  • Preserve existing assertions for platform links, box art, ranking order, and empty states.
  • Run the focused popular-game card tests before closing the issue.
  • Run vendor/bin/pint --dirty --format agent before implementation closeout if PHP files change.

Progress Checklist

  • Identify where cached popular-game URLs are generated
  • Fix current-year popular game URL generation or rendering
  • Fix upcoming popular game URL generation or rendering
  • Confirm platform links remain valid
  • Add localhost regression coverage for both popular cards
  • Run focused popular-game card tests
  • Run vendor/bin/pint --dirty --format agent if PHP files changed
  • Move the issue out of Codex review once verification is complete
The most popular game cards should link to real MyVideoGameList game and platform pages, not localhost URLs that only work in a local development environment. The current-year and upcoming popular game cards are shown across public pages, so broken host-specific links make the ranked game lists unusable for visitors even when the card content renders correctly. ## Scope - Current-year Most Popular Games card links. - Most Popular Upcoming Games card links. - Generated game detail URLs used for title and box art links. - Generated platform URLs shown under popular game rows. - Existing populated and empty-state card layouts. ## Acceptance Criteria - Game title links in both popular cards navigate to the correct game detail route. - Box art links in both popular cards use the same valid game detail route as the title. - Platform links continue to navigate to the correct platform route when platform metadata is present. - Rendered popular-card HTML does not contain hardcoded localhost URLs. - Empty popular-card states continue to render when no games qualify. - The existing public page layout and light/dark styling are preserved. ## Test Coverage Required - Extend `MostPopularGamesCardTest` to assert current-year game links are route-based and do not contain `localhost`. - Extend `MostPopularUpcomingGamesCardTest` to assert upcoming game links are route-based and do not contain `localhost`. - Preserve existing assertions for platform links, box art, ranking order, and empty states. - Run the focused popular-game card tests before closing the issue. - Run `vendor/bin/pint --dirty --format agent` before implementation closeout if PHP files change. ## Progress Checklist - [x] Identify where cached popular-game URLs are generated - [x] Fix current-year popular game URL generation or rendering - [x] Fix upcoming popular game URL generation or rendering - [x] Confirm platform links remain valid - [x] Add localhost regression coverage for both popular cards - [x] Run focused popular-game card tests - [x] Run `vendor/bin/pint --dirty --format agent` if PHP files changed - [x] Move the issue out of Codex review once verification is complete
Codex changed title from The links in both most popular lists are set to localhost to Fix Localhost Links in Most Popular Game Cards 2026-06-19 14:43:32 -05:00
Codex self-assigned this 2026-06-19 17:02:18 -05:00
Codex commented 2026-06-19 19:05:26 -05:00
Member
Copy link

Implemented in dev commit 982d9b3.

Summary:

  • Popular game metadata now stores root-relative game and platform route URLs instead of APP_URL-derived absolute URLs.
  • Current-year popular cache keys were bumped to v2 and upcoming popular cache keys to v4 to avoid reusing cached localhost links.
  • Current-year and upcoming card tests now assert title and box art share the same game href, platform links remain valid, and each card fragment does not contain localhost.

Verification:

  • php artisan test --compact tests/Feature/MostPopularGamesCardTest.php tests/Feature/MostPopularUpcomingGamesCardTest.php
  • vendor/bin/pint --dirty --format agent
Implemented in dev commit 982d9b3. Summary: - Popular game metadata now stores root-relative game and platform route URLs instead of APP_URL-derived absolute URLs. - Current-year popular cache keys were bumped to v2 and upcoming popular cache keys to v4 to avoid reusing cached localhost links. - Current-year and upcoming card tests now assert title and box art share the same game href, platform links remain valid, and each card fragment does not contain localhost. Verification: - php artisan test --compact tests/Feature/MostPopularGamesCardTest.php tests/Feature/MostPopularUpcomingGamesCardTest.php - vendor/bin/pint --dirty --format agent
Codex commented 2026-06-19 19:14:01 -05:00
Member
Copy link

Final review notes:

  • The fix landed in dev at commit 982d9b3.
  • Current-year popular game links are generated by App\Support\PopularGameRanker; upcoming popular game links are generated by App\Support\UpcomingPopularGames.
  • Both services now store root-relative games.show and platform.show route URLs, so cached card metadata no longer depends on APP_URL and cannot cache http://localhost links for visitors.
  • Cache keys were intentionally bumped to site:most-popular-games:v2:* and site:most-popular-upcoming-games:v4:* so old cached absolute URLs are bypassed.
  • The rendered-card regression assertions are scoped to the popular-card fragments because the full homepage can include unrelated localhost strings from normal app configuration/assets in local test runs.

Verification re-run during review:

  • php artisan test --compact tests/Feature/MostPopularGamesCardTest.php tests/Feature/MostPopularUpcomingGamesCardTest.php — 12 passed, 102 assertions
  • vendor/bin/pint --dirty --format agent — passed
Final review notes: - The fix landed in `dev` at commit `982d9b3`. - Current-year popular game links are generated by `App\Support\PopularGameRanker`; upcoming popular game links are generated by `App\Support\UpcomingPopularGames`. - Both services now store root-relative `games.show` and `platform.show` route URLs, so cached card metadata no longer depends on `APP_URL` and cannot cache `http://localhost` links for visitors. - Cache keys were intentionally bumped to `site:most-popular-games:v2:*` and `site:most-popular-upcoming-games:v4:*` so old cached absolute URLs are bypassed. - The rendered-card regression assertions are scoped to the popular-card fragments because the full homepage can include unrelated localhost strings from normal app configuration/assets in local test runs. Verification re-run during review: - `php artisan test --compact tests/Feature/MostPopularGamesCardTest.php tests/Feature/MostPopularUpcomingGamesCardTest.php` — 12 passed, 102 assertions - `vendor/bin/pint --dirty --format agent` — passed
Codex 2026-06-19 19:14:06 -05:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
dev
No results found.
Labels
Clear labels   
automated

   
code-quality

   
component: admin dashboard
The issue is related to the admin dashboard functionality.

  
component: backend
The issue is related to the backend code.

  
component: billing
The issue is related to our billing and payment system functionality.

  
component: content management
The issue is related to site content and moderation functionality.

  
component: faqs
The issue relates to our frequency asked questions and their categories.

  
component: game genres
The issue is related to genres in relation to games.

  
component: game lists
The issue is related to user-facing game list functionality.

  
component: game reviews
The issue relates to the game reviews functionality.

  
component: game search
The issue is related to the user-facing game search functionality.

  
component: games
The issue relates to games in our database.

  
component: internal notifications
The issue is related to the functionality of notifications sent for internal usage.

  
component: platforms
The issue is related to platform functionality.

  
component: security
The issue relates to the security issues within the app.

  
component: tests
The issue relates to unit and feature tests.

  
component: user api
The issue relates to the user-facing API.

  
component: user badges
The issue is related to our badge/achievements functionality.

  
component: user blogs
The issue is related to blogging functionality.

  
component: user consoles
The issue is related to user console lists functionality.

  
component: user favorites
This is issue is related to the favorites functionality.

  
component: user friends
The issue relates to the friending functionality.

  
component: user notifications
The issue is related to user-facing notifications functionality.

  
component: user profiles
The issue is related to user profile functionality.

  
component: user site notifications
The issue relates to the functionality of notifications shown to users directly on the website.

  
component: user wishlists
This issue is related to the wishlists functionality.

  
component: web design
This issue is related to the design of the website.

  
dependencies
Pull requests that update a dependency file.

  
php
Pull requests that update PHP code.

  
priority
high
 The issue is considered a high priority.

  
priority
low
 This issue is considered a low priority.

  
priority
medium
 This issue is considered a medium priority.

  
security-hotspot

   
source: codex

   
source: sonarqube
  
status
awaiting feedback
 The issue is awaiting feedback from others.

  
status
backlog
 Issues that are in a backlog status.

  
status
done
 The issue has been completed and closed out.

  
status
in progress
 The issue is in progress and being actively worked on.

  
status
in queue
 The issue is in queue and will be worked on shortly.

  
status
in review
 The issue work has been completed and now the work needs to be reviewed.

  
status
needs codex review
 Use this tag to have Codex spiffy up your issue.

  
status
needs investigation
 The issue describes a problem which needs further investigation.

  
status
wontfix
 This issue will not be worked on.

  
type: bug
The issue describes something working the way it wasn't intended too.

  
type: documentation
Improvements or additions to site documentation.

  
type: feature
A new feature for the website.

  
type: improvement
An improvement on an existing feature.

  
type: regression
The issue describes a function that previously worked and no longer does.

  
type: task
A small-ish task.

No labels
automated
code-quality
component: admin dashboard
component: backend
component: billing
component: content management
component: faqs
component: game genres
component: game lists
component: game reviews
component: game search
component: games
component: internal notifications
component: platforms
component: security
component: tests
component: user api
component: user badges
component: user blogs
component: user consoles
component: user favorites
component: user friends
component: user notifications
component: user profiles
component: user site notifications
component: user wishlists
component: web design
dependencies
php
priority
high
priority
low
priority
medium
security-hotspot
source: codex
source: sonarqube
status
awaiting feedback
status
backlog
status
done
status
in progress
status
in queue
status
in review
status
needs codex review
status
needs investigation
status
wontfix
type: bug
type: documentation
type: feature
type: improvement
type: regression
type: task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Laravel 13 + TailwindCSS
Assignees
Clear assignees
No assignees
Codex
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
MyVideoGameList/myvideogamelist.com#765
No description provided.