SonarQube MAJOR CODE_SMELL: Define and throw a dedicated exception instead of using a generic one. #906

New issue

Closed

opened 2026-08-04 16:56:33 -05:00 by forgejo-actions · 1 comment

forgejo-actions commented

2026-08-04 16:56:33 -05:00

SonarQube issue detected.

SonarQube key: 981bffa8-90e8-4541-8c2f-22a8bd936faa
Severity: MAJOR
Type: CODE_SMELL
Location: myvideogamelist:app/Console/Commands/SyncProductionSnapshot.php:218
Message: Define and throw a dedicated exception instead of using a generic one.

https://sonarqube.linuxbox.ninja/project/issues?id=myvideogamelist&issues=981bffa8-90e8-4541-8c2f-22a8bd936faa&open=981bffa8-90e8-4541-8c2f-22a8bd936faa

SonarQube issue detected. **SonarQube key:** `981bffa8-90e8-4541-8c2f-22a8bd936faa` **Severity:** `MAJOR` **Type:** `CODE_SMELL` **Location:** `myvideogamelist:app/Console/Commands/SyncProductionSnapshot.php:218` **Message:** Define and throw a dedicated exception instead of using a generic one. https://sonarqube.linuxbox.ninja/project/issues?id=myvideogamelist&issues=981bffa8-90e8-4541-8c2f-22a8bd936faa&open=981bffa8-90e8-4541-8c2f-22a8bd936faa

forgejo-actions added the

labels

2026-08-04 16:56:33 -05:00

Codex self-assigned this

2026-08-04 18:50:33 -05:00

Codex added the

status

in progress

label

2026-08-04 18:50:34 -05:00

Codex referenced this issue from a pull request that will close it,

2026-08-04 21:48:17 -05:00

Resolve SonarQube production sync findings #914

jimmyb closed this issue

2026-08-04 21:53:25 -05:00

Codex commented

2026-08-04 21:55:29 -05:00

Member

Resolved by PR #914.

Notes for future readers:

Content flag test-only Sonar findings were handled by extracting repeated profile/content literals into named constants and replacing the nested ternary helper with explicit owner resolution.
The unused ContentFlagTargetResolver::isHidden() $type parameter was removed because the method resolves hidden state from the model class and id.
Production sync command findings were handled by introducing ProductionSyncCommandException, using it for command/preflight/process failures, and splitting the production data/snapshot command flow into smaller helpers to reduce return count and cognitive complexity.
The legacy mvgl:sync-production-snapshot command remains retired per docs/DEV_PRODUCTION_PARITY.md; the cleanup preserves its existing dry-run/write/rollback behavior while satisfying the analyzer.

Verification from the PR:

php artisan test --compact tests/Feature/ContentFlagTest.php tests/Feature/ProductionDataSyncCommandTest.php tests/Feature/ProductionSnapshotCommandTest.php
vendor/bin/pint --dirty --format agent
composer stan

Resolved by PR #914. Notes for future readers: - Content flag test-only Sonar findings were handled by extracting repeated profile/content literals into named constants and replacing the nested ternary helper with explicit owner resolution. - The unused `ContentFlagTargetResolver::isHidden()` `$type` parameter was removed because the method resolves hidden state from the model class and id. - Production sync command findings were handled by introducing `ProductionSyncCommandException`, using it for command/preflight/process failures, and splitting the production data/snapshot command flow into smaller helpers to reduce return count and cognitive complexity. - The legacy `mvgl:sync-production-snapshot` command remains retired per `docs/DEV_PRODUCTION_PARITY.md`; the cleanup preserves its existing dry-run/write/rollback behavior while satisfying the analyzer. Verification from the PR: - `php artisan test --compact tests/Feature/ContentFlagTest.php tests/Feature/ProductionDataSyncCommandTest.php tests/Feature/ProductionSnapshotCommandTest.php` - `vendor/bin/pint --dirty --format agent` - `composer stan`

Codex added

and removed

labels

2026-08-04 21:55:33 -05:00