Fix clipped comment-report modal #940

Closed
opened 2026-08-30 12:26:11 -05:00 by Veilor · 1 comment
Member

The comment-report dialog is visually clipped, preventing users from reliably viewing or submitting the report form.

The issue is isolated to the presentation and responsive layout of the existing comment-report UI.

Scope

  • Inspect the existing comment-report view and its associated CSS classes.
  • Adjust modal sizing, overflow, stacking, and responsive behavior so the complete dialog remains visible within the viewport.
  • Preserve the existing report submission and validation behavior.

Acceptance Criteria

  • The complete comment-report dialog, including its fields, actions, and close control, is visible without being obscured by the backdrop or surrounding content.
  • The dialog remains usable on narrow and wide viewports without horizontal clipping.
  • The backdrop and dialog stacking order do not hide dialog content.
  • Existing report submission, cancellation, and validation behavior remains unchanged.

Test Coverage Required

  • Add or update a feature test covering that the comment-report UI is rendered for the applicable comment action.
  • Add browser or view-level coverage for the dialog at a narrow viewport if the repository's existing test conventions support it.
  • Run the existing focused comment-related test coverage after implementation.

Progress Checklist

  • Locate the comment-report view and associated styling in resources/views and resources/css.
  • Reproduce the clipping behavior and identify the responsible size, overflow, or stacking rule.
  • Implement the smallest responsive layout correction in the existing UI surface.
  • Add focused regression coverage using the repository's established test patterns.
  • Review the resulting dialog at narrow and wide viewport sizes.
The comment-report dialog is visually clipped, preventing users from reliably viewing or submitting the report form. The issue is isolated to the presentation and responsive layout of the existing comment-report UI. ## Scope - Inspect the existing comment-report view and its associated CSS classes. - Adjust modal sizing, overflow, stacking, and responsive behavior so the complete dialog remains visible within the viewport. - Preserve the existing report submission and validation behavior. ## Acceptance Criteria - The complete comment-report dialog, including its fields, actions, and close control, is visible without being obscured by the backdrop or surrounding content. - The dialog remains usable on narrow and wide viewports without horizontal clipping. - The backdrop and dialog stacking order do not hide dialog content. - Existing report submission, cancellation, and validation behavior remains unchanged. ## Test Coverage Required - Add or update a feature test covering that the comment-report UI is rendered for the applicable comment action. - Add browser or view-level coverage for the dialog at a narrow viewport if the repository's existing test conventions support it. - Run the existing focused comment-related test coverage after implementation. ## Progress Checklist - [x] Locate the comment-report view and associated styling in resources/views and resources/css. - [x] Reproduce the clipping behavior and identify the responsible size, overflow, or stacking rule. - [x] Implement the smallest responsive layout correction in the existing UI surface. - [x] Add focused regression coverage using the repository's established test patterns. - [x] Review the resulting dialog at narrow and wide viewport sizes.
Codex changed title from The comment report box gets cut offf to Fix clipped comment-report modal 2026-08-30 12:26:41 -05:00
Codex self-assigned this 2026-10-05 12:58:35 -05:00
Member

Completed in PR #960, merged into master as c5c6f86399.

The clipping came from the compact report form's fixed 320px width and absolute positioning inside cards with overflow-hidden. Profile and game comment reports now use the existing Tailwind Plus native modal pattern, which escapes card clipping and keeps the backdrop behind the form. Dialogs have unique IDs, accessible titles, Close/Cancel controls, Escape dismissal, and focus restoration. Short landscape viewports use internal vertical scrolling to keep the fields and actions reachable. Guest login controls and the noncompact profile-bio report form are unchanged; existing report endpoints, validation, and POST fields are preserved.

Verification:

  • 49 focused content-flag, user-profile, and game-profile tests passed (399 assertions).
  • All 12 Playwright tests passed, including actual rendered Blade with built CSS/JavaScript at 320px, 375px, desktop, and short landscape sizes in light/dark themes. Coverage includes reason selection, reachable actions, cancellation without submission, focus return, and submitted form data.
  • Pint, PHPStan, the asset build, and both Forgejo PR CI jobs passed. The full CI PHP suite completed without failures, though its summary reported 677 warnings.

Deployed the merged revision to both production and development on October 5, 2026. All 409 runtime file checksums matched on each site; homepage, login, platforms, and contact pages returned HTTP 200, and the served CSS/JavaScript matched the release. Application caches were refreshed, rollback backups retained, and no migrations were run. Deployment verification used read-only smoke checks and did not create live content reports.

All acceptance criteria and required test coverage were reviewed, and all five progress checklist items are complete.

Completed in PR #960, merged into master as c5c6f86399d456c1e0ad16cd36a97fa612dee9dd. The clipping came from the compact report form's fixed 320px width and absolute positioning inside cards with overflow-hidden. Profile and game comment reports now use the existing Tailwind Plus native modal pattern, which escapes card clipping and keeps the backdrop behind the form. Dialogs have unique IDs, accessible titles, Close/Cancel controls, Escape dismissal, and focus restoration. Short landscape viewports use internal vertical scrolling to keep the fields and actions reachable. Guest login controls and the noncompact profile-bio report form are unchanged; existing report endpoints, validation, and POST fields are preserved. Verification: - 49 focused content-flag, user-profile, and game-profile tests passed (399 assertions). - All 12 Playwright tests passed, including actual rendered Blade with built CSS/JavaScript at 320px, 375px, desktop, and short landscape sizes in light/dark themes. Coverage includes reason selection, reachable actions, cancellation without submission, focus return, and submitted form data. - Pint, PHPStan, the asset build, and both Forgejo PR CI jobs passed. The full CI PHP suite completed without failures, though its summary reported 677 warnings. Deployed the merged revision to both production and development on October 5, 2026. All 409 runtime file checksums matched on each site; homepage, login, platforms, and contact pages returned HTTP 200, and the served CSS/JavaScript matched the release. Application caches were refreshed, rollback backups retained, and no migrations were run. Deployment verification used read-only smoke checks and did not create live content reports. All acceptance criteria and required test coverage were reviewed, and all five progress checklist items are complete.
Sign in to join this conversation.
No milestone
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MyVideoGameList/myvideogamelist.com#940
No description provided.