MyVideoGameList/myvideogamelist.com
MyVideoGameList/myvideogamelist.com
Watch
3
0
Fork
You've already forked myvideogamelist.com
 0
Code Issues 33 Pull requests 3 Projects 2 Releases Activity Actions

Resolve seven SonarQube findings #957

Merged
jimmyb merged 1 commit from codex/fix-sonarqube-950-956 into master 2026-10-02 17:11:06 -05:00
Conversation 2 Commits 1 Files changed 10 +102 -31
Codex commented 2026-10-02 16:01:24 -05:00
Member
Copy link

Resolve seven SonarQube findings while preserving badge metadata, game-list queries, retired-staff migration guards, and friendship behavior.

Split badge catalog generation into smaller groups and move friendship relationships into a model concern. Use named constants for repeated query/test literals and a dedicated retired-staff prerequisite exception. Move the profile's inline Blade conditional outside its anchor tag so the HTML analyzer does not misread later form attributes.

Verification: badge catalog/evaluator, game-list, user profile/friendship, and retired-staff migration tests pass; Pint and PHPStan pass. SonarQube runs on master after merge, so scanner confirmation is pending that run.

Fixes #950
Fixes #951
Fixes #952
Fixes #953
Fixes #954
Fixes #955
Fixes #956

Resolve seven SonarQube findings while preserving badge metadata, game-list queries, retired-staff migration guards, and friendship behavior. Split badge catalog generation into smaller groups and move friendship relationships into a model concern. Use named constants for repeated query/test literals and a dedicated retired-staff prerequisite exception. Move the profile's inline Blade conditional outside its anchor tag so the HTML analyzer does not misread later form attributes. Verification: badge catalog/evaluator, game-list, user profile/friendship, and retired-staff migration tests pass; Pint and PHPStan pass. SonarQube runs on master after merge, so scanner confirmation is pending that run. Fixes #950 Fixes #951 Fixes #952 Fixes #953 Fixes #954 Fixes #955 Fixes #956
Resolve seven SonarQube findings
All checks were successful
linter / quality (pull_request) Successful in 8m26s
Details
tests / ci (pull_request) Successful in 16m57s
Details
ef2492f0d8
jimmyb self-assigned this 2026-10-02 16:04:50 -05:00
Codex commented 2026-10-02 16:08:43 -05:00
Author
Member
Copy link

Local verification passed: 105 distinct focused tests covering badges, game-list pagination, profiles, friendships, and retired-staff migration prerequisites, plus Pint and PHPStan.

Forgejo test run #1159 failed during runner setup, before checkout or any tests ran: the mariadb:12.3 service container never became healthy. Master run #1157 failed at the same step with the same health-check error, so this is a pre-existing CI infrastructure blocker.

The test job needs a rerun once the MariaDB service startup problem is resolved. SonarQube confirmation remains pending the master scan after merge.

Local verification passed: 105 distinct focused tests covering badges, game-list pagination, profiles, friendships, and retired-staff migration prerequisites, plus Pint and PHPStan. Forgejo test run #1159 failed during runner setup, before checkout or any tests ran: the mariadb:12.3 service container never became healthy. Master run #1157 failed at the same step with the same health-check error, so this is a pre-existing CI infrastructure blocker. The test job needs a rerun once the MariaDB service startup problem is resolved. SonarQube confirmation remains pending the master scan after merge.
Codex commented 2026-10-02 16:28:23 -05:00
Author
Member
Copy link

Final verification: Forgejo quality #1158 and ci #1159 attempt 2 passed. The retry passed MariaDB migrations, asset build, browser interaction checks, and the full PHP suite (5,034 assertions; existing suite warnings were reported). The initial MariaDB setup failure cleared on retry. Local focused runs covered 109 distinct tests, correcting the earlier count of 105. SonarQube confirmation remains pending the master scan after merge.

Final verification: Forgejo quality #1158 and ci #1159 attempt 2 passed. The retry passed MariaDB migrations, asset build, browser interaction checks, and the full PHP suite (5,034 assertions; existing suite warnings were reported). The initial MariaDB setup failure cleared on retry. Local focused runs covered 109 distinct tests, correcting the earlier count of 105. SonarQube confirmation remains pending the master scan after merge.
jimmyb merged commit bcf894f81b into master 2026-10-02 17:11:06 -05:00
jimmyb deleted branch codex/fix-sonarqube-950-956 2026-10-02 17:11:06 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
automated

   
code-quality

   
component: admin dashboard
The issue is related to the admin dashboard functionality.

  
component: backend
The issue is related to the backend code.

  
component: billing
The issue is related to our billing and payment system functionality.

  
component: content management
The issue is related to site content and moderation functionality.

  
component: faqs
The issue relates to our frequency asked questions and their categories.

  
component: game genres
The issue is related to genres in relation to games.

  
component: game lists
The issue is related to user-facing game list functionality.

  
component: game reviews
The issue relates to the game reviews functionality.

  
component: game search
The issue is related to the user-facing game search functionality.

  
component: games
The issue relates to games in our database.

  
component: internal notifications
The issue is related to the functionality of notifications sent for internal usage.

  
component: platforms
The issue is related to platform functionality.

  
component: security
The issue relates to the security issues within the app.

  
component: tests
The issue relates to unit and feature tests.

  
component: user api
The issue relates to the user-facing API.

  
component: user badges
The issue is related to our badge/achievements functionality.

  
component: user blogs
The issue is related to blogging functionality.

  
component: user consoles
The issue is related to user console lists functionality.

  
component: user favorites
This is issue is related to the favorites functionality.

  
component: user friends
The issue relates to the friending functionality.

  
component: user notifications
The issue is related to user-facing notifications functionality.

  
component: user profiles
The issue is related to user profile functionality.

  
component: user site notifications
The issue relates to the functionality of notifications shown to users directly on the website.

  
component: user wishlists
This issue is related to the wishlists functionality.

  
component: web design
This issue is related to the design of the website.

  
dependencies
Pull requests that update a dependency file.

  
javascript
Pull requests that update Javascript code

  
php
Pull requests that update PHP code.

  
priority
high
 The issue is considered a high priority.

  
priority
low
 This issue is considered a low priority.

  
priority
medium
 This issue is considered a medium priority.

  
security-hotspot

   
source: codex

   
source: sonarqube
  
status
awaiting feedback
 The issue is awaiting feedback from others.

  
status
backlog
 Issues that are in a backlog status.

  
status
done
 The issue has been completed and closed out.

  
status
in progress
 The issue is in progress and being actively worked on.

  
status
in queue
 The issue is in queue and will be worked on shortly.

  
status
in review
 The issue work has been completed and now the work needs to be reviewed.

  
status
needs codex review
 Use this tag to have Codex spiffy up your issue.

  
status
needs investigation
 The issue describes a problem which needs further investigation.

  
status
wontfix
 This issue will not be worked on.

  
type: bug
The issue describes something working the way it wasn't intended too.

  
type: documentation
Improvements or additions to site documentation.

  
type: feature
A new feature for the website.

  
type: improvement
An improvement on an existing feature.

  
type: regression
The issue describes a function that previously worked and no longer does.

  
type: task
A small-ish task.

No labels
automated
code-quality
component: admin dashboard
component: backend
component: billing
component: content management
component: faqs
component: game genres
component: game lists
component: game reviews
component: game search
component: games
component: internal notifications
component: platforms
component: security
component: tests
component: user api
component: user badges
component: user blogs
component: user consoles
component: user favorites
component: user friends
component: user notifications
component: user profiles
component: user site notifications
component: user wishlists
component: web design
dependencies
javascript
php
priority
high
priority
low
priority
medium
security-hotspot
source: codex
source: sonarqube
status
awaiting feedback
status
backlog
status
done
status
in progress
status
in queue
status
in review
status
needs codex review
status
needs investigation
status
wontfix
type: bug
type: documentation
type: feature
type: improvement
type: regression
type: task
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
jimmyb
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MyVideoGameList/myvideogamelist.com!957
No description provided.